Duplicate Items/Ruin Reports/Sites Lost

If you find a bug please report it here

Duplicate Items/Ruin Reports/Sites Lost

Postby KGB » Tue Oct 04, 2011 10:39 pm

A few bugs I noticed today:

1) The Ruin regeneration is no longer reported to players. I found in game 3602 (LOTR1) a ruin I had searched a couple of turns ago repopulated. I did not see anything in the History report to say that it did nor did it appear in my 'news' at the start of the turn.

2) Searching this ruin again yielded the 'Ring of Ishmael'. I am positive I have already gotten this item from another ruin a few turns ago (that hero was killed so my opponent (Green) now would hold that item) since it has a much welcome Command bonus.

3) the news text at the start of the turn said I lost a gold site. In reality, I lost a lookout tower. I would have been annoyed to lose a gold site but a lookout tower wasn't important. Maybe the news text should identify the difference between a gold site and a lookout tower.

KGB
KGB
 
Posts: 3030
Joined: Tue Feb 16, 2010 12:06 am

Re: Duplicate Items/Ruin Reports/Sites Lost

Postby SnotlinG » Wed Oct 05, 2011 5:31 pm

1.
Looking at your game, I see the entry:

TURN 7
<snip>
The ruin Grey Tower is again haunted by evil!

So it looks like it was there, maybe you missed it in the News popup?

2.
Yes I see there are a duplicate in your game :-(
I´ll investigate this further.

3. Yes currently Towers, LookOutTowers and Goldsites are all counted as goldsites.
Might change it into 2 or 3 categories for Beta5
SnotlinG
 
Posts: 2148
Joined: Sat Feb 13, 2010 12:42 am

Re: Duplicate Items/Ruin Reports/Sites Lost

Postby KGB » Wed Oct 05, 2011 10:14 pm

SnotlinG,

Nope, I never saw that message.

In fact I had been noticing in all my games that I had not seen a ruin repopulate in *forever*. I was actually going to post a message about it in the forum asking if that had gotten broken somehow until I spotted the regenerated ruin purely because I did a mouse over and thought the text was buggy.

KGB
KGB
 
Posts: 3030
Joined: Tue Feb 16, 2010 12:06 am

Re: Duplicate Items/Ruin Reports/Sites Lost

Postby SnotlinG » Thu Oct 06, 2011 3:17 pm

Ok strange.
I checked and tested the code again now and it seems to be working.

The entry should come on top of all the reports of lost units/sites etc, and it doesnt have the small shield-icon that some of the entries has... Keep an eye open and let me know if they still doesnt show.
SnotlinG
 
Posts: 2148
Joined: Sat Feb 13, 2010 12:42 am

Re: Duplicate Items/Ruin Reports/Sites Lost

Postby KGB » Thu Oct 06, 2011 5:04 pm

SnotlinG,

I'll look for it in all my games and let you know the next time I see one in any of my 5-6 games.

One question though, do you have to have the ruin unfogged to get the message? Because I know the ruin was fogged in the case I mentioned.

Also regarding duplicate items. Is there a reason why we can't have duplicates? I know War2/DLR didn't allow them but War4 allowed duplicate items in the same game with the idea that minor/major items could be duplicated (like a +1 Sword in AD&D) but artifacts could not and were unique. Since you already have minor/major classifications maybe you just want to classify a few as artifacts and make those unique (the L3 ruin items) and allow the rest to be duplicated.

KGB
KGB
 
Posts: 3030
Joined: Tue Feb 16, 2010 12:06 am

Re: Duplicate Items/Ruin Reports/Sites Lost

Postby Jeremy » Thu Oct 06, 2011 7:07 pm

I just got one of my level 1 ruins repopulated on the Rivalry map.

Searched it again. Got the same item -- the +3 Defense skeletal shield.

Not sure how much I care, but it felt a little strange to get the same item twice.
Jeremy
 
Posts: 214
Joined: Thu Dec 09, 2010 3:51 pm

Re: Duplicate Items/Ruin Reports/Sites Lost

Postby SnotlinG » Fri Oct 07, 2011 7:35 am

KGB, no all players get the information, as well as their FOW-information updated (i.e. changing ruin status to Unexplored).

As for the items, well havent thought that much about it, just a feeling that since the items have unique names it seems weird to have duplicates in the same game/world...
SnotlinG
 
Posts: 2148
Joined: Sat Feb 13, 2010 12:42 am

Re: Duplicate Items/Ruin Reports/Sites Lost

Postby SnotlinG » Mon Nov 21, 2011 8:54 pm

Ok, finally got around to fix this bug in the beta5 code. It should now not create duplicate items :-)

Also added some additional info to the event notification regarding regenerated ruins, now it looks like
"Located in the southwest of the map, the ruin Monument of Garak is again haunted by evil!"

Not sure if I have mentioned it, but also the lost goldsites is slightly updated like:

You have lost 0 cities since last turn.
You have lost 0 towers since last turn.
You have lost 0 goldsites since last turn.
SnotlinG
 
Posts: 2148
Joined: Sat Feb 13, 2010 12:42 am


Return to Bug reports

Who is online

Users browsing this forum: No registered users and 6 guests

cron
Not able to open ./cache/data_global.php