Orange and Yellow reversed somewhere in the code

If you find a bug please report it here

Orange and Yellow reversed somewhere in the code

Postby Jeremy » Mon Jan 02, 2012 5:59 pm

I've seen this on my Middle Earth map -- but it's likely always been true. We just didn't notice, because traditionally start locations were assigned randomly.

Problem: Sign up to be the Yellow Dwarves, on team Good.

Result: You start the game as the Orange Harad on team Evil.

(And vice versa, of course.)

--------------

Problem: I assign 'Team Good' as Green (Fellowship), Teal (Rohan), Blue (Gondor) and Yellow (Dwarves)

Result: Orange (Harad) is incorrectly on the team, Yellow (Dwarves) is incorrectly on team Evil.

(For now, I've set up the teams intentionally wrong, so that the the teams come out right after the incorrect switch.)


Not sure if these two problems are 1 place in the code, or two different places in the code.
Jeremy
 
Posts: 214
Joined: Thu Dec 09, 2010 3:51 pm

Re: Orange and Yellow reversed somewhere in the code

Postby SnotlinG » Tue Jan 03, 2012 2:10 pm

Hello,

I tried to replicate the issue, but for me it works. Also checked the code and could not find any issues (this is far from any guarantee though since it sometimes seems to contain an unlimited amount of bugs ;-) )
I tried hosting the official scenariomap twice, and both times I ended up with the expected color/team.

Do you have any game currently running where they ended up on the wrong side?
SnotlinG
 
Posts: 2148
Joined: Sat Feb 13, 2010 12:42 am

Re: Orange and Yellow reversed somewhere in the code

Postby Jeremy » Mon Jan 16, 2012 3:46 pm

Still seeing the problem. On the Middle Earth map, if you sign up to be the Yellow, Dwarves of the Northeast (who should be on Team Good) it actually makes your the Orange Harad of the South. (Who should be on Team Evil with Mordor, Saruman and the Orcs, but incorrectly get put on Team Good with the Fellowship, Gondor and Rohan.

But it's not just the team selection -- I explicitly choose the Yellow Dwarves, and it made me Orange Harad instead.

Currently seeing in game ME 2 x 2 2
Jeremy
 
Posts: 214
Joined: Thu Dec 09, 2010 3:51 pm

Re: Orange and Yellow reversed somewhere in the code

Postby LPhillips » Mon Jan 16, 2012 6:05 pm

Game 5971. I'm on Evil with the Iron Dwarves instead of Harad, which I picked. I thought the game had given us random starts. In other news, playing Iron Dwarves with a few bad dice rolls can really, really piss you off. "Well, in another 3 turns, I can try to conquer something." Hah.
LPhillips
 
Posts: 965
Joined: Mon Jan 24, 2011 3:25 am

Re: Orange and Yellow reversed somewhere in the code

Postby SnotlinG » Wed Jan 18, 2012 10:20 am

Ok Im trying to track this down.
Im checking game 5971.
As far as I can tell the team looks right; Green,Blue,Orange,Teal is on one team vs the other four.
Also starting locations looks right, yellow is starting top right, which is what he should start according to the map
Checking the log from the gamecreation I am told that LPhillips was on slot 2 and picked color Yellow (i.e. Dwarfes).
Can you confirm that you actually picked orange in the gamelobby?
SnotlinG
 
Posts: 2148
Joined: Sat Feb 13, 2010 12:42 am

Re: Orange and Yellow reversed somewhere in the code

Postby SnotlinG » Wed Jan 18, 2012 10:40 am

Jeremy, if you know how we can recreate the problem, could you please host a password protected game where I join and then we launch. If I understand it correctly if I choose Yellow in the gamelobby, I will then turn out to be orange when the game is launched? (so I will be on the other team, since orange is on the other team compared to yellow). So far I have not been able to replicate the problem :-(

*EDIT* I created a game named "Admintest A" (password snotling) with your account on your map, and have joined with you and myself. Please check if this setup is what should give us wrong colors when we launch it?
I have picked Orange on slot 7, so i guess I should become Yellow when the game launches?
SnotlinG
 
Posts: 2148
Joined: Sat Feb 13, 2010 12:42 am

Re: Orange and Yellow reversed somewhere in the code

Postby LPhillips » Wed Jan 18, 2012 3:53 pm

You know, at this point, I'm thoroughly confused. Jeremy said that he had the teams for those players reversed until recently to counter the bug, so that makes it hard to tell if the bug is still happening or it's because of what Jeremy did to counter it.

At this point I'm not 100% sure which spawn I picked. Dwarves should be on the other team, not on Evil, but that might be because Jeremy reversed them in an attempt to counter the bug. My memory of it just isn't clear enough. Sorry!
LPhillips
 
Posts: 965
Joined: Mon Jan 24, 2011 3:25 am

Re: Orange and Yellow reversed somewhere in the code

Postby Jeremy » Wed Jan 18, 2012 6:45 pm

Tried to start game. Had 2 players, 6 positions closed. Click on 'Launch', it Incorrectly says something similar to: 'The slots must be filled by players before beginning'

In any case, I'll do some testing tonight as well, see if I'm still seeing it.
Jeremy
 
Posts: 214
Joined: Thu Dec 09, 2010 3:51 pm

Re: Orange and Yellow reversed somewhere in the code

Postby SnotlinG » Wed Jan 18, 2012 8:03 pm

The game was started by the server at least. Need to check that manual starting.
I got orange, and started in the south, which is what i expected?

Could you host another one and we can check if the correct colors/names/teams are setup?
SnotlinG
 
Posts: 2148
Joined: Sat Feb 13, 2010 12:42 am


Return to Bug reports

Who is online

Users browsing this forum: No registered users and 29 guests

cron
Not able to open ./cache/data_global.php