Hero offers with insufficient money

[Chazar]

I have received several heroes offers now without having sufficient money.

At first, I thought the explanation was simulatneous turns and loosing money due to the enemy conquering a city, but now I have one of those on turn 2, without loosing anything.

I have 156 Gold and a Hero is offered for 419 Gold.

Its in game 38111. I did move my other hero to an L1 ruin in hope of finding enough gold, but I did not. In any case, searching a ruin should not loose gold.

So is it intentional to see hero offers below one's current gold?

[SnotlinG]

No it is not intentional.
I am trying to track this bug since a few days.
Have you only seen this in simultaneous games?
Whats the gamename / gameid of the game you are seeing this now?
When you got your offer, was it possible to press the OK button even though you didnt have enough gold, or was it grayed out?

[Chazar]

Game id is 38111 (as posted above).

Unfortunately, I do not recall whether the offer would have worked. I always click cancel right away to assess the game's situation first. However, I feel that it might be possible: I has sometimes have the feeling that there is a bug with the total gold amount.

Since this game is on turn 2, it should be possible to work out the total gold amount I ought have (EDIT: I recalculated and the amount shown now is correct). I will have another look, and I will try to take more care from now on when I get hero offers.

And yes, I believe I have only seen it in simultaneous turn games, but that might just be a coincidence.

Is the code that piranha posted in the scarce-hero-thread still up to date?

[SnotlinG]

I think that code is more or less uptodate.
However I have a feeling the issue is connected to simultaneous games, as all the players golds are calculated at the same time. I have so far been unable to find the bug though, so any discovery on your side would be good.
For example points of interest would be:

- When you get such an offer, are you the first player doing a turn that game or has some other player already done that turn
- Does the client show you an incorrect amount of gold? I.e. if you hit F5, does it then show you another (lower) value?

[SnotlinG]

I think I actually found the bug now when looking through the code once again.
I had missed an " ORDER BY playerID" in my query, so sometimes it was checking for hero offers using your opponents gold...

Fixed now so hopefully we shouldnt see this again

Thanks for reporting and let me know if you see something suspicious again...