ingame messages cut at special chars now

[Chazar]

Since today, a lot of my (past) ingame communication is now cut mid-word where the first special character would be expected, e.g. the german umlauts ä ö ü. Games in version v0.9 and older do not seem to be affected.

This is very annoying, as I cannot read what my allies wanted to communicate with me. In some instances, the whole message ends after the first few characters, not even forming a complete single word.

[SnotlinG]

Hello Chazar,
Is this something that started happening just now?
Thats strange...
Do you have any game I can look where you have this issue`?

[Chazar]

I only noticed it today using my PC. Yesterday I was only online for very short times using my Android Nexus mostly.

I see the bug in all my v0.91 games, and it does also affect messages from previous turns that were once shown in full, including my own messages:

• 39385 - (I just wrote a testmessage to everyone in this game to reproduce the error! The message in english says what is missing)
• 39384 - (4 out of 5 message mangled - the one ok message does not contain german umlauts)
• 39283 - (just one message)

When I sent the test message in 39385 about 10 minutes ago, it was displayed alright at first. However, after exiting that game, looking into another one and returning, the message is now cut off right before the first german umlaut.

[SnotlinG]

Ok, I see the issue. Lets see if I can solve it somehow

Thanks for reporting it!

[SnotlinG]

Hello,
I think I have found and fixed the issue (earlier messages are corrupt/lost though).
Please try it a bit now and see if the characters are showed correctly?

I think we have a similiar issue in the community private chats, but lets get the ingame chat working properly first and then we can take care of the other chat...

[Chazar]

I did two tests and it seems to work ok now, as in V0.9 and earlier (which were not affected, tested it earlier today). Thanks.

BTW, there is still the old issue with quotes ' and double-quotes " not being properly unescaped in the messages either.

I don't know Javascript, but I find it quite strange that you have these problems at all?! For my own webservers, I just use standard library functions that pack and unpack a user's UTF8 text input, which takes care of all these escaping and security issues for me.

[SnotlinG]

Thanks for letting me know about quotes issue.
Should be solved now.

Without going into too much detail, pretty much all our code is custom built, which might explain why we have those annoying issues. We have for version 0.91 changed connection characterset to the database also, which in turn affected some of our code.
There is also a difference between messages that gets sent out to you while you are online and messages that you read from the database while loading the game, which explains why they could look good first and then on second load of the game they looked corrupted. I have now tested all scenarios I can think of for the gamechat for 0.91 and it seems to be working
let me know if you see any similiar issue

[Chazar]

Works great now, thank you for fixing the quotes too!

Well, I guess everyone gets the Debug-Hell they deserve.

[Chazar]

Yet another related bug:
Newlines are not displayed correctly in in-game messages when these are received online.

If I sent a message with newlines, these disappear once the message is displayed on the right-hand side with the received messages. However, upon reloading the client, the newlines are then displayed correctly. So this is another issue between messages being processed locally versus obtained from the server's database.

[SnotlinG]

Fixed!