auto-hero accept

[kenc80]

ok this may not be a bug just me being clumsy but twice in a game I'm playing I've "bought" heroes I don't remember buying. The issue comes whenever I minimize the warbarons web page and when I come back to the page I find I have bought the hero even though I did not accept it at first. I'm using Chrome. It doesnt happen everytime but every once in a while it will.

So what happens is I usually play with gmail and warbarons up on separate tabs in chrome. If i start a turn with a hero offer, I'll decline it and say an email pops up. I'll switch over to look at the email. When I switch back it like auto-buys the hero.

its weird.

[Pillager]

I have had several similar experiences (also using google chrome).

I cancel the hero offer (closing the window)...but I still end up getting the hero. I believe this happens because the 'ok' button from the hero offers window remains active (but invisible) after I close the window. When I click the mouse in the area the 'ok button' would be (if the hero offers window was open), the hero is accidentally hired...causing me to curse my fate.

[kenc80]

that sounds fairly accurate. really really frustrating...especially in tight games.

[SnotlinG]

Fixed!

[Pillager]

Whoop!

That makes me happy.

Snotling, thou dost rock!

[kenc80]

yes WOOHOO!!!!! was that what the problem was? you're my hero Snotling!

[SnotlinG]

Yes, our main "problem" I guess is that we are re-using popup windows, so the popup with the hero offer, is actually the same window/html code as the city popup, etc. We populate it with diffrent info, and then add diffrent onclick-attributes to the OK button depending on what we want to trigger when OK is clicked.

The problem here was that in some ways you could open the city info popup (like clicking on an enemy city) without resetting the onclick-attribute for the OK button, thus when clicking OK in the citypopup you actually accepted the Hero offer.

I have gone through all our references to that OK-button and made updates where it was missing the reset of the button, so I would be surprised if we get the same issue again

[KGB]

SnotlinG,

I have noticed something else with hero offers that *may* be a bug. I say may because I've never been able to test it.

But when you get a hero offer, if you accept the offer and buy the hero, you can still click on the hero offers button and get the same offer again. Now, I've never had enough gold to be able to buy the same hero twice but I wonder if I could if I had the gold.

KGB

[SnotlinG]

Yes you are correct. I noticed this when fixing the other hero bug but then forgot about it.

Its been fixed now also

It was just a small bug in the client, on the serverside the hero was bought/processed correctly, so even if you had money you wouldnt have been able to buy two heroes

[kenc80]

am bringing this back up because it just happened to me again...definitely probably a mis-click on my part...

However, I think Hero offers are so important and critical (this hero accept means i am now out of money and have basically now hopelessly lost a close game) that they should get an "are you sure? prompt-box. I think that would save a lot of people trouble if it were able to be implemented. If that is hard to code then dont worry about it but if its easy then I think it would be good to have that extra question when accepting heroes.

KenC